plan and apply terraform commands error outputs printed after a new line Fixes #121

[anubhavmishra]

No description provided.

[lkysow]

in plan executor

	output, err := p.terraform.RunCommandWithVersion(ctx.Log, filepath.Join(repoDir, project.Path), tfPlanCmd, terraformVersion)
	if err != nil {
		// plan failed so unlock the state
		if _, err := p.lockingClient.Unlock(lockAttempt.LockKey); err != nil {
			ctx.Log.Err("error unlocking state: %v", err)
		}
		return ProjectResult{Error: fmt.Errorf("%s\n%s", err.Error(), output)}
	}

it uses the output result.

Same as in apply

	output, err := a.terraform.RunCommandWithVersion(ctx.Log, absolutePath, tfApplyCmd, terraformVersion)
	if err != nil {
		return ProjectResult{Error: fmt.Errorf("%s\n%s", err.Error(), output)}
	}

So we could return the output instead of just the err. What do you think?

[anubhavmishra]

So you mean for the ProjectResult return something like this:

return ProjectResult{Error: fmt.Errorf("%s", output)}

[lkysow]

no that code is fine, I just mean from terraform_client return the output and err, right now it does return "", err

[anubhavmishra]

oh right. yea that makes sense to me.