Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use workspace instead of env for tf >=0.10 #219

Merged
merged 2 commits into from
Dec 18, 2017
Merged

Use workspace instead of env for tf >=0.10 #219

merged 2 commits into from
Dec 18, 2017

Conversation

lkysow
Copy link
Collaborator

@lkysow lkysow commented Dec 18, 2017

  • Use workspace instead of env for TF versions >= 0.10 since this was deprecated in 0.10 and is not allowed in 0.11
  • Use the word Workspace everywhere in the codebase to avoid confusion

Fixes #197

@codecov-io
Copy link

Codecov Report

Merging #219 into master will increase coverage by 0.61%.
The diff coverage is 72.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage    63.5%   64.11%   +0.61%     
==========================================
  Files          39       38       -1     
  Lines        1759     1750       -9     
==========================================
+ Hits         1117     1122       +5     
+ Misses        592      578      -14     
  Partials       50       50
Impacted Files Coverage Δ
server/events/markdown_renderer.go 91.3% <ø> (ø) ⬆️
server/events/apply_executor.go 0% <0%> (ø) ⬆️
server/events/atlantis_workspace.go 0% <0%> (ø)
server/events/run/run.go 61.11% <100%> (ø) ⬆️
server/events/atlantis_workspace_locker.go 100% <100%> (ø)
server/server.go 72.3% <100%> (ø) ⬆️
server/events/pull_closed_executor.go 94.59% <100%> (ø) ⬆️
server/events/project_pre_execute.go 96.07% <100%> (ø) ⬆️
server/events/locking/locking.go 100% <100%> (ø) ⬆️
server/events/command_handler.go 89.65% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0109bcf...7c1220a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants