Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'SetBaseURL' to correctly set GitLab URL #231

Merged
merged 4 commits into from
Jan 16, 2018
Merged

Conversation

lkysow
Copy link
Collaborator

@lkysow lkysow commented Jan 16, 2018

No description provided.

jrasell and others added 4 commits January 12, 2018 14:51
This change updates server/server.go to set the GitLab URL using
the `Client.SetBaseURL` to set the base URL off of the configured
param. Previosuly even if a user set the `--gitlab-hostname` the
default URL for GitLab would not overriden to match this.

Closes #227
@codecov-io
Copy link

Codecov Report

Merging #231 into master will decrease coverage by 0.32%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   64.11%   63.78%   -0.33%     
==========================================
  Files          38       38              
  Lines        1750     1759       +9     
==========================================
  Hits         1122     1122              
- Misses        578      587       +9     
  Partials       50       50
Impacted Files Coverage Δ
server/server.go 69.36% <0%> (-2.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b26dbb...6d67178. Read the comment docs.

@lkysow lkysow merged commit dd766b8 into master Jan 16, 2018
@lkysow lkysow deleted the jrasell-b_gh_227 branch January 16, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants