Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combo Counter Flickering #101

Open
rocamocha opened this issue Jan 29, 2023 · 2 comments · May be fixed by #106
Open

Combo Counter Flickering #101

rocamocha opened this issue Jan 29, 2023 · 2 comments · May be fixed by #106

Comments

@rocamocha
Copy link

The combo counter flickers, I would like to keep it on but at the moment it's very distracting.
@ao-shen
Copy link

ao-shen commented Feb 18, 2023 •
edited
Loading

This is also a bug in my fork.

This happens because the previous combo decoration is being disposed before the new one is created.

This can be fixed simply by disposing the previous decoration only after the new one is created and rendered.

@ao-shen ao-shen linked a pull request Feb 18, 2023 that will close this issue
Open
@drfree1
Copy link

drfree1 commented Sep 14, 2023

I am still having the same issue as i can see pull request solves the issue why it doesn't get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed combo meter decoration flickering Computer-Kids-Club/vscode-power-mode
3 participants
@ao-shen @rocamocha @drfree1