Fixed combo meter decoration flickering #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combo meter flicker BUG This happens because the previous combo decoration is being disposed before the new one is created. This can be fixed simply by disposing the previous decoration only after the new one is created and rendered.
|
Thank you |
drfree1
approved these changes
Sep 14, 2023
|
Thx so much! I changed it by myself. (I copied your complete file src/combo/editor-combo-meter.ts) in the original git (cloned) and then created a vsix file and installed this file. Great fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
Combo meter flicker BUG
This happens because the previous combo decoration is being disposed before the new one is created.
This can be fixed simply by disposing the previous decoration only after the new one is created and rendered.