Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule do not turn off if resolving fails #2

Merged
merged 1 commit into from
May 31, 2024

Conversation

charlottexl
Copy link

@charlottexl charlottexl commented May 31, 2024

Rule do not turn off if resolving fails.

Avoid thanos-ruler exiting directly when query or alertmanager resolving parsing errors occur.

Rule do not turn off if resolving fails.

Signed-off-by: lian.xue <[email protected]>
Copy link
Owner

@hoperays hoperays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoperays hoperays merged commit 3fd64a8 into hoperays:release-0.32-es May 31, 2024
@charlottexl charlottexl deleted the fix-ruler-exit branch May 31, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants