Refactor: remove fmtm-splitter and Update Profile Endpoints #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
nrjadkry
reviewed
Sep 6, 2024
| @@ -130,7 +130,7 @@ <h2>Mapping Task Details</h2> | |||
| <p><strong>Project:</strong>{{project_name}}</p> | |||
| <p><strong>Description:</strong> {{description}}</p> | |||
| </div> | |||
| <a href="dronetm.naxa.com.np" class="task-button" | |||
| <a href="https://dronetm.org/" class="task-button" | |||
There was a problem hiding this comment.
We should take a base url from env.
There was a problem hiding this comment.
We should take a base url from env.
@nrjadkry Good point! I've updated the code to load the base URL from the environment variables.
nrjadkry
reviewed
Sep 6, 2024
src/backend/app/config.py
Outdated
| @@ -80,6 +80,7 @@ def assemble_db_connection(cls, v: Optional[str], info: ValidationInfo) -> Any: | |||
| ) | |||
| return pg_url | |||
|
|
|||
| SITE_URL: str = "http://localhost:3040" | |||
There was a problem hiding this comment.
Better to name it FRONTEND_URL ?
nrjadkry
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fmtm-splitter: Eliminated thefmtm-splitterdependency; the project now uses a separateTaskSplitteralgorithm for area splitting.FRONTEND_URLfrom environment files and set a dynamic URL for click button.