Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove auth bypass in roles.check_access for HOTOSM org #1785

Closed
spwoodcock opened this issue Sep 16, 2024 · 0 comments · Fixed by #1845
Closed

Remove auth bypass in roles.check_access for HOTOSM org #1785

spwoodcock opened this issue Sep 16, 2024 · 0 comments · Fixed by #1845
Assignees
@spwoodcock
Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:high Should be addressed as a priority
Milestone
(2024.5.0) genera...

Comments

@spwoodcock
Copy link
Member

Describe the bug

Follow on from #1759

  • We need to enable proper auth in FMTM, disabling the bypass for the HOTOSM organisation.

To do

  • Remove the code in the SQL that bypasses auth.
  • Thoroughly test endpoints and check things work properly with access levels.
@spwoodcock spwoodcock added bug Something isn't working priority:high Should be addressed as a priority backend Related to backend code effort:low Likely a few hours labels Sep 16, 2024
@spwoodcock spwoodcock self-assigned this Sep 23, 2024
This was referenced Oct 24, 2024
Closed
Closed
Anuj-Gupta4 added a commit to Anuj-Gupta4/fmtm that referenced this issue Oct 30, 2024
@Anuj-Gupta4
fixes: Remove auth bypass in for HOTOSM org hotosm#1785
7bb71a5
@Anuj-Gupta4 Anuj-Gupta4 mentioned this issue Oct 30, 2024
Merged
1 task
Anuj-Gupta4 added a commit to Anuj-Gupta4/fmtm that referenced this issue Nov 8, 2024
@Anuj-Gupta4
fixes: Remove auth bypass in for HOTOSM org hotosm#1785
6484926
spwoodcock pushed a commit that referenced this issue Nov 11, 2024
@Anuj-Gupta4
fix(backend): remove auth bypass in for HOTOSM org #1785 (#1845)
831f055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spwoodcock spwoodcock

Labels
backend Related to backend code bug Something isn't working effort:low Likely a few hours priority:high Should be addressed as a priority
Projects
Field Mapping Tasking Manager (FMTM)
Status: Done
Milestone
(2024.5.0) general bugfixes / improve...
Development

Successfully merging a pull request may close this issue.

fixes: Remove auth bypass in for HOTOSM org #1785 Anuj-Gupta4/fmtm
1 participant
@spwoodcock