Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down UI strings without {{ | translate }} #1234

Closed
ethan-nelson opened this issue Oct 14, 2018 · 3 comments
Closed

Track down UI strings without {{ | translate }} #1234

ethan-nelson opened this issue Oct 14, 2018 · 3 comments

Comments

@ethan-nelson
Copy link
Contributor

Translations on the front end are handled using the {{ a string or sentence here | translate }} syntax. There are some strings that do not have this syntax. Here's a prime example.

Please note: This does not apply specifically to returned errors from the API. Perhaps in the future we can look at a mechanism for translating these (probably by loading all errors with translations and substituting them in real time).

Also, if anyone has experience with including html as a string substitution in these types of places, that would be welcomed. Something like (pythonically) "Please make sure to register at %s for OSM" % (link). That would be easier than making translators include the HTML code in their translations or breaking up strings outside the links. Here's an example of that which we're doing right now:
https://github.com/hotosm/tasking-manager/blob/develop/client/app/home/home.html#L91

@DorukUlucay
Copy link
Contributor

DorukUlucay commented Oct 24, 2018

Hello. I'm interested. Can you assign it to me ?

Edit: Looks like resolved in another issue. If not, i'm interested.

@ethan-nelson
Copy link
Contributor Author

Hi @DorukUlucay yes we have PR addressing many, if not all, of these. There may be a few that are missed by the PR, so feel free to check back after that is merged in a few days. Thanks for your interest.

@ethan-nelson
Copy link
Contributor Author

This may not be 100% but the number remaining has been greatly reduced in #1235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants