Add {{ | translate }} #1235
Merged
Add {{ | translate }} #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add {{ 'x' | translate }} to text which did not have it
|
Hi @bonalybob I will be reviewing this PR in the next two days. Thank you! |
|
Thanks again for filing this @bonalybob . I've been going through the changes and things look good--we're holding off on merges until this last big set of changes is merged from develop to master--but I had one question. It looks like in many places you took HTML tags that were split across a few lines and combined them into one. Was that based on lint-er output or something else? |
|
I think the code has been reformatted by a linter |
ethan-nelson
approved these changes
Dec 5, 2018
|
Thank you @brownben for your help! |
|
Oops, didn't mean to close--only comment |
This was referenced Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add {{ 'x' | translate }} to UI strings which did not have it.
For Issue #1234