Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Random Task Selection #1583

Closed
zlavergne opened this issue May 16, 2019 · 3 comments · Fixed by #1726
Closed

Enforce Random Task Selection #1583

zlavergne opened this issue May 16, 2019 · 3 comments · Fixed by #1726

Comments

@zlavergne
Copy link

zlavergne commented May 16, 2019

Internally, we have implemented a feature called Enforce Random Task Selection.

Implementation:

  • Optional setting to Enforce Random Task Selection
    image

  • If Enforce Random Task Selection is enabled, users will not be able to manually select tasks. They will be required to use the "Select A Random Task" button (does not apply to pm/admins)
    image

  • Errors appear if they try to select a task from the map
    image

From a separate discussion, it sounds like for this to be valuable for HOT, the functionality of random selection needs to change to choose tasks in priority areas first.

@xamanu @russdeffner That shouldn't be difficult to add but should I change the global functionality of "Select A Random Task" to always select tasks in priority areas or only when "Enforce Random Task Selection" is enabled?

@zlavergne
Copy link
Author

@xamanu random task selection and task assignment aren't really related but they were built in parallel. It shouldn't be too much overhead to split them into separate PR's.

@pantierra pantierra added this to the 3.4 Release milestone May 23, 2019
@zlavergne
Copy link
Author

@xamanu @russdeffner I mentioned during the last TMWG call that the current "Select A Random Task" feature is a regression from TM2 and since there isn't a need for the more robust feature internally, I'd like to port this over as is. I should have the PR ready next week

@pantierra pantierra added status: in progress and removed type: enhancement Improving an existing functionality labels Jun 5, 2019
@pantierra
Copy link
Contributor

From a separate discussion, it sounds like for this to be valuable for HOT, the functionality of random selection needs to change to choose tasks in priority areas first.

This has been also mentioned in #955.

@pantierra pantierra added the type: enhancement Improving an existing functionality label Jun 5, 2019
zlavergne pushed a commit that referenced this issue Jun 26, 2019
* Add optional setting to Enforce Random Task Selection in the project's edit page

* If Enforce Random Task Selection is enabled, users will not be able to manually select tasks. They will be required to use the "Select A Random Task" button (does not apply to pm/admins)

* Errors appear if they try to select a task from the map

Closes #1583
ramyaragupathy pushed a commit that referenced this issue Jul 10, 2019
Change circleci deployment branches

Enable RDS Cloudwatch Logging and transactional logs

Change ASG Policy to Target Request Count threshold

Include into migration a cleanup for task_ids on messages for tasks, which don't exist anymore

Scripts to restore deleted projects

Update translations

Avoid providing standard changeset comment

Add required ResourceLabel param to ASG policy

Optimize gulp watch to only track files inside our project and not the
whole node_modules dir, it uses less CPU this way.

Clean up deprecated windows devops script

Include additional fields on tests

Allow expert validators to classify mapping issues

> Note: this includes a new database migration

* Show validators in expert mode an additional form allowing them to
(optionally) classify the type and number of problems they discover with
mapping work that is leading to invalidation of the task

* Record identified mapping issues in a `task_mapping_issues` database
table

* Display noted mapping issues in the task history immediately below the
invalidation where they were recorded

* Allow mapping issues fixed by the validator on behalf of the mapper
to be noted when marking a task as validated

* Display in the task history when a task was validated with fixes, and
show the identified list of issues addressed by the validator

* Add a new page, accessible from the account-nav dropdown menu, on
which project managers and admins can manage the available mapping-issue
categories

* Seed the mapping-issue categories with a couple of initial categories

* Add server RESTful API endpoints for managing mapping-issue categories

* Add new `mapping_issue_categories` and `task_mapping_issues` database
tables in new migration

* Add support on server for optional inclusion of noted mapping issues
during task validation/invalidation

Remove What is New page

Correct time calculations in user profile (#1571)

Correct time calculations in user profile

Add Task Annotations

Update migration and fix minor default value issue

Mapper-level icons and encouragement messages

* Show a trophy icon in the top-nav in a color representing the
logged-in user's mapping level (bronze, silver, or gold for beginner,
intermediate, or advanced respectively), and also prominently display
user's mapping level on their profile page

* Show message on home page and profile page encouraging mappers to
continue mapping and advance to the next level (or to try validating in
the case of advanced mappers)

View changesets in OSMCha. Closes #1362

* Add button to task's Advanced section for viewing a task's changesets
in OSMCha

* Add button for viewing project-wide changesets in OSMCha, visible to
users with validator or higher role (expert or higher for projects that
don't enforce a validator role)

* Add new column to projects for storing an OSMCha filter id that can be
optionally used to load a custom OSMCha filter in place of the standard
project-wide filters for projects that require a more customized set of
filters

* A project's OSMCha filter id can be managed from the Metadata section
when creating or editing a project

Use smaller RDS instances for non production stacks (#1657)

* use cheaper rds instances for non production stacks

* configurable min/max

Show expert users ISO8601 timestamps on hover

* Users in expert mode can hover over a timestamp to view it in IS08601
format

* Clicking the ISO8601 timestamp copies it to the user's clipboard

* Users who are not in expert mode continue to experience existing
behavior

Transfer project to new owner feature, fixes #1341

Fix tasks annotations and complete with tasks details

Add recommended oauth settings in documentation

Update contributing-code.md

Correct typo in title

Add instruction for local development in setup-development.md

Adding link to user manual on teachosm.org

Add markdown support to task annotations

Support Korean

Update eslint to 4.18.2

Restructure scripts a bit

Review documentation on TM2 migration

Modify deployment for new stack

Modify rds instance size to m5.xlarge

Calculate stats in the database

Fixes: #1720

Enforce Random Task Selection

* Add optional setting to Enforce Random Task Selection in the project's edit page

* If Enforce Random Task Selection is enabled, users will not be able to manually select tasks. They will be required to use the "Select A Random Task" button (does not apply to pm/admins)

* Errors appear if they try to select a task from the map

Closes #1583

Consolidating the stats on tasks

Block read_only user comments on projects

Some documentation and sorting of API tags

Include validators #1685 + Separate time calcs

Restructure the endpoints

Remove additional comma

Update method type

Percentage and Centroid fields

Calculate task status percentages on projects in one central function

Prevent SQL Injection when executing custom SQL

Fixes: #1731

Include automatic trigger for indexing text_searchable

Enforces PM or Admin role on the users that will get a transfered project

Add script to extract strings for translation

Block start mapping and start validating options if email is not set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants