Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Editor Options #1916

Closed
zlavergne opened this issue Oct 10, 2019 · 6 comments
Closed

Custom Editor Options #1916

zlavergne opened this issue Oct 10, 2019 · 6 comments

Comments

@zlavergne
Copy link

zlavergne commented Oct 10, 2019

I'd like to discuss a new feature that will allow Project Managers to add a custom editor endpoint to a project that will be added as an additional option in the dropdown list:
image

The plan is to add it as a "Custom" option to the editor options in the "Settings" section of the edit-project page.

cc @xamanu

@pantierra
Copy link
Contributor

pantierra commented Oct 15, 2019

Yes, I think that makes the TM much more flexible. Maybe we just want to show the possibility to add those custom endpoints only for project managers, that have the "Expert mode" switched on.

Probably we'd need three fields for it.

  • Name
  • URL
  • Notes

While the notes should be displayed, when users select this editor before hitting "start".

@russdeffner
Copy link

I think this is good as long as it still allows the PM the ability to only allow specific editors. In project creation there is already the check-boxes to display/not-display editors in the drop-down. So this custom would also need populated there.

@zlavergne
Copy link
Author

zlavergne commented Oct 15, 2019

@xamanu Sounds like I'm heading in the right direction. I've got the backend set up and just to clarify - right now, I'm doing one "Custom Editor" per project that a PM will then be able to toggle between mapping and validation.

@russdeffner are you saying that we should do sanity checks to make sure the URL they're adding isn't already an option as one of the baked in editors?

@russdeffner
Copy link

@zlavergne - that, but more along the lines of... if I only want mappers using the custom editor or JOSM, that I can still do that in Settings.

@zlavergne
Copy link
Author

if I only want mappers using the custom editor or JOSM, that I can still do that in Settings.

@russdeffner I'll try to have a screen capture of how this will look in a few hours but that's the plan 😄

@pantierra
Copy link
Contributor

This is in by now. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants