Custom Editor

[zlavergne]

Note: This PR requires a migration

With this PR, a PM with expert mode enabled can add a custom editor to a project.

Demos

Project edit

Mapping

Note: This will currently only work with iD-ish urls or JOSM urls that don't require parameters.

cc @xamanu @russdeffner

closes #1916

[pantierra]

Checked and reviewed. Works fine and source code it good.

[fitoria]

I got this error, doing the following steps.

• Add a custom editor
• Enabled it
• Remove custom editor
• Add custom editor again.

CRITICAL in project_admin_api: Project GET - unhandled error: (psycopg2.IntegrityError) null value in column "enabled" violates not-null constraint
DETAIL:  Failing row contains (4, test, test desc, http://testeditor.com, null).

[SQL: UPDATE project_custom_editors SET name=%(name)s, description=%(description)s, url=%(url)s, enabled=%(enabled)s WHERE project_custom_editors.project_id = %(project_custom_editors_project_id)s]
[parameters: {'name': 'test', 'description': 'test desc', 'url': 'http://testeditor.com', 'enabled': None, 'project_custom_editors_project_id': 4}]
(Background on this error at: http://sqlalche.me/e/gkpj)

The field seems to not being sent

[zlavergne]

@fitoria figured it out. Long story short, since I was using an uninitialized ng-model (projectCtrl.customEditor) when rendering, the checkbox was set to null. When the rest of the data was input but the checkbox wasn't toggled, nothing triggered projectCtrl.customEditor.enabled to ever be initialized.

I decided to fix this on the backend by:

1. changing the default for the column in the model to False
2. adding the same default to the DTO object

[pantierra]

Rerolled after a conflict with newest master after PR #1918 and catched up to newest migration. Tested it again and it is good to go.