Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expert augmented diff and attic query controls #1271

Merged

Conversation

nrotstan
Copy link
Contributor

  • Add new control for users in expert mode to each history entry in task
    history table for viewing an augmented diff between two entries or attic
    query data for a single entry

  • Selecting two separate entries will show an augmented diff of the
    changes between those entries in Achavi in a new browser tab

  • Selecting the same entry twice will perform an attic query and open
    the data in either JOSM (if the user has selected it as their editor) or
    Overpass Turbo in a new browser tab

  • Add new atticQueryOffsetMinutes config setting for adjusting history
    entry timestamps for the purpose of querying attic data to ensure that
    data has had time to become available (defaults to 10 minutes)

  • Reorganize some of the projectController bbox code into separate
    methods to facilitate easier reuse

attic

* Add new control for users in expert mode to each history entry in task
history table for viewing an augmented diff between two entries or attic
query data for a single entry

* Selecting two separate entries will show an augmented diff of the
changes between those entries in Achavi in a new browser tab

* Selecting the same entry twice will perform an attic query and open
the data in either JOSM (if the user has selected it as their editor) or
Overpass Turbo in a new browser tab

* Reorganize some of the projectController bbox code into separate
methods to facilitate easier reuse
@ethan-nelson ethan-nelson self-assigned this Dec 22, 2018
Copy link
Contributor

@ethan-nelson ethan-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • controls appear when expert mode activated, disappear when deactivated
  • double clicking new box shows changes in overpass turbo
  • double clicking with JOSM selected opens amazingly
  • clicking different boxes opens augmented diff in achavi with time differential (e.g. when selecting a mark done and comment, they have the same time and so changes don't show up--while selecting two different marked done shows differences)
  • old view osm changesets button still works
  • old view in overpass turbo button still works, and verified each user shows up for node, way, and relation

@ethan-nelson
Copy link
Contributor

Thanks @nrotstan !

@russdeffner do we have an advanced validator training curriculum--or is there a better place we could start collecting information on expert mode features? I think a wiki page in the TM GitHub repo is warranted to for non-HOT users.

@ethan-nelson ethan-nelson merged commit 4fd54b5 into hotosm:develop Jan 6, 2019
@ethan-nelson ethan-nelson mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants