Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matomo tracking code #1288

Merged
merged 6 commits into from
Jan 10, 2019
Merged

Add matomo tracking code #1288

merged 6 commits into from
Jan 10, 2019

Conversation

dakotabenjamin
Copy link
Member

Adds tracking js for the new tracking site. We are not removing the piwik tracking code yet.

@dakotabenjamin
Copy link
Member Author

This needs work still, please hold off merging

@ethan-nelson ethan-nelson changed the title Add matomo tracking code [WIP] Add matomo tracking code Dec 1, 2018
@dakotabenjamin
Copy link
Member Author

dakotabenjamin commented Dec 15, 2018

We are ready for testing- some notes:

  • the tracking code control can be found at https://github.com/hotosm/matomo-tracking/
  • the privacy policy link goes to hotosm.org/privacy which currently doesn't exist (404)
  • I need to set up some continuous integration on the matomo tracking repo to upload updates to s3 without breaking current builds (hence the versioned file).
  • feel free to squash and merge this one if that functionality is enabled for this repo
  • This will remove tracking for piwik.hotosm.org. It's not simply possible to do so when working with an external js file

@dakotabenjamin dakotabenjamin changed the title [WIP] Add matomo tracking code Add matomo tracking code Dec 15, 2018
@ethan-nelson
Copy link
Contributor

@dakotabenjamin let me know if I can help with testing in some way. Otherwise we can just throw this new code in and test it out on develop?

@dakotabenjamin
Copy link
Member Author

@ethan-nelson please check the client that the popup shows up on the bottom of the page. Make sure you have cookies enabled and script blockers disabled.

The code update I just pushed incorporates hotjar tracking so we can look at pointer movements and clicks

@smit1678
Copy link
Contributor

smit1678 commented Jan 7, 2019

@dakotabenjamin @ethan-nelson I haven't tested this but one thing realizing here is that on smaller screens and mobile is that we have the Mapswipe banner. So we'll have a banner on top of a banner. Perhaps we need to have a class on the Matomo banner to put it at the top? or are we ok with the interaction of first hitting the Matomo banner and then dealing with the mobile banner. Thoughts?

@dakotabenjamin
Copy link
Member Author

Can we do that with the z-index? The matomo banner is at index 1001 and the mobile banner is index 4.

Copy link
Contributor

@ethan-nelson ethan-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code works

@dakotabenjamin dakotabenjamin merged commit 61b6116 into develop Jan 10, 2019
@ethan-nelson ethan-nelson mentioned this pull request Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants