update readme to add local dev postgres environment instruction #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
suggested changes
Apr 16, 2019
README.md
Outdated
| @@ -121,6 +121,7 @@ The backend server is made up of a postgres database and an associated API that | |||
| - `TM_SECRET`=define-freely-any-number-and-letter-combination | |||
| - `TM_CONSUMER_KEY`=oauth-consumer-key-from-openstreetmap | |||
| - `TM_CONSUMER_SECRET`=oauth-consumer-secret-key-from-openstreetmap | |||
| * Adjust server/config.py to set `POSTGRES_ENDPOINT = os.getenv('POSTGRES_ENDPOINT', 'localhost')` | |||
There was a problem hiding this comment.
I think the instructions are not the case for all kind of setups. And I don't want users to encourage changing the config.py. Woudn't the setup work with a POSTGRES_ENDPOINT=localhost? And maybe find a phrase to be more open to any kind of setup.
There was a problem hiding this comment.
@xamanu I have updated the pr.
uwaiszaki
force-pushed
the
uwais_readme1
branch
from
76c5fef
to
52f5ba4
Compare
|
This should be moved to |
|
@uwaiszaki could you please include `POSTGRES_PORT variable also? |
|
@xamanu @JorgeMartinezG I have updated the pr, please give your reviews. Thanks |
pantierra
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update readme for the fix of #1479.