[WIP] Restrict project edit only to author and admin #1574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
added
status: in progress
type: enhancement
|
If we are going to restrict editing, I would say one definite need would be the ability to delegate to or add other project managers the edit capability. Some activations rely on teams of PMs (that may not be admins). |
|
Yesterday, due to emergency (#1687) a partial advancement of this has been applied. Please review this PR to build on top of the lastest changes again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a fix for #1504 . For now the restriction is done in the client side. Projects are limited to authors and admins to edit or delete actions.
I want to iterate through this Pull request and know your opinions @ethan-nelson @xamanu. Would be necessary to make the restriction also on the server side also?