Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce command to extract strings for translations, make them required for any changes and update documentation #1706

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Introduce command to extract strings for translations, make them required for any changes and update documentation #1706

merged 1 commit into from
Jul 8, 2019

Conversation

pantierra
Copy link
Contributor

@pantierra pantierra commented Jun 19, 2019 •
edited
Loading

  • Adds a script to extract strings for translations into json files
  • Add make command to call the script
  • Adjust link to renamed transifex project
  • Update en.json file, which is the source for the translation and it is getting pulled from develop automatically now. This will make sure people are always translating for develop and before the release we have to pull the files down and include them.
  • Complete documentation
  • Added test for unupdated en.json file (comparing it with the code base)

@pantierra pantierra self-assigned this Jun 19, 2019
@pantierra pantierra force-pushed the feature/1678-translations branch 4 times, most recently from 878b100 to 79871b1 Compare June 19, 2019 11:36
@pantierra pantierra removed their assignment Jun 19, 2019
@pantierra pantierra added this to the 3.4 Release milestone Jun 19, 2019
@pantierra pantierra force-pushed the feature/1678-translations branch 5 times, most recently from 7a82abc to 87e13b9 Compare June 19, 2019 13:53
@pantierra pantierra changed the title Add script to extract strings for translations Update translations and add script to manage them Jun 19, 2019
@pantierra pantierra changed the title Update translations and add script to manage them Add script to extract strings for translations and update documentation Jun 19, 2019
@pantierra pantierra force-pushed the feature/1678-translations branch 6 times, most recently from 71c4070 to 997b416 Compare June 19, 2019 23:06
@pantierra pantierra changed the title Add script to extract strings for translations and update documentation Introduce command to extract strings for translations, make them required for any changes and update documentation Jun 19, 2019
@pantierra pantierra force-pushed the feature/1678-translations branch 2 times, most recently from 34b9e8c to 9c857de Compare June 19, 2019 23:35
@ethan-nelson
Copy link
Contributor

back in town 👍 will review this weekend

@pantierra pantierra mentioned this pull request Jun 24, 2019
Closed
@pantierra pantierra force-pushed the feature/1678-translations branch 4 times, most recently from bcbaac2 to e379d0f Compare June 25, 2019 10:51
ethan-nelson
ethan-nelson approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@ethan-nelson ethan-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment you may be interested to fix. Otherwise looks good!

@pantierra pantierra merged commit db44e0d into develop Jul 8, 2019
@pantierra pantierra deleted the feature/1678-translations branch July 8, 2019 11:57
@pantierra pantierra mentioned this pull request Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethan-nelson ethan-nelson ethan-nelson approved these changes

Assignees
No one assigned
Labels
priority: medium scope: frontend type: enhancement Improving an existing functionality
Projects
None yet
Milestone
3.4 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@pantierra @ethan-nelson