Add project due date #3153
Merged
Add project due date #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaovitor3
force-pushed
the
feature/add-project-due-date
branch
from
d6bf7f3
to
4e63050
Compare
willemarcel
reviewed
Jun 23, 2020
There was a problem hiding this comment.
@joaovitor3 react-datepicker is a good choice. Could you try to set the locale using what is defined by the user preferences?
|
@joaovitor3 try also to format the input field with the same height of the text input fields. |
|
Thanks for the review! |
willemarcel
added
scope: frontend
status: in progress
type: enhancement
joaovitor3
force-pushed
the
feature/add-project-due-date
branch
from
4e63050
to
0cc59cc
Compare
|
@willemarcel, Just updated the PR with the changes requested. |
pantierra
reviewed
Aug 27, 2020
joaovitor3
force-pushed
the
feature/add-project-due-date
branch
from
0cc59cc
to
b921082
Compare
|
Just rebased the branch, could you review it please? |
joaovitor3
force-pushed
the
feature/add-project-due-date
branch
from
f723969
to
9b69e12
Compare
willemarcel
force-pushed
the
feature/add-project-due-date
branch
2 times, most recently
from
e35d21a
to
534290d
Compare
willemarcel
force-pushed
the
feature/add-project-due-date
branch
from
534290d
to
6473341
Compare
willemarcel
force-pushed
the
feature/add-project-due-date
branch
from
6473341
to
301bfcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3132
This Pull Request is part of the issue of adding and updating fields according to Organised Editing Guidelines
Add project
due_datefield in frontend.