Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry integration #3600

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Conversation

willemarcel
Copy link
Contributor

No description provided.

@willemarcel willemarcel added this to the 4.1.9 milestone Sep 15, 2020
@willemarcel willemarcel changed the title add sentry integration Add sentry integration to backend Sep 15, 2020
import sentry_sdk
from sentry_sdk.integrations.flask import FlaskIntegration

sentry_sdk.init(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dakotabenjamin is NetworkEnvironment available as a ENV VAR to the backend?
To set the environment on sentry, we just need to add environment=foo here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@willemarcel willemarcel Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can. Could we change the env var from NEW_RELIC_ENVIRONMENT to TM_ENVIRONMENT? So if we stop using NewRelic, we don't need to change the env var and make the variable name more expressive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEW_RELIC_ENVIRONMENT is something used internally by New Relic, so we can't change it.

@willemarcel willemarcel changed the title Add sentry integration to backend Add sentry integration Sep 17, 2020
@willemarcel
Copy link
Contributor Author

@dakotabenjamin I also added sentry to the frontend and adjusted the backend sample rate

@willemarcel willemarcel force-pushed the feature/sentry-backend-integration branch from f3cdad0 to 538c1cd Compare September 17, 2020 23:30
@dakotabenjamin
Copy link
Member

@willemarcel I added the environment variable assignment, and made the generic "TM_ENVIRONMENT" envvar. For production it will show up as "tm4-production".

Copy link
Member

@dakotabenjamin dakotabenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on aws and was able to get the key to work in Sentry, but it says it's being rate limited. I'm not able to trigger any issues manually either. Everthing else seems to be working, so perhaps we merge into staging and test from there?

@willemarcel willemarcel force-pushed the feature/sentry-backend-integration branch from 0aefb31 to c4fe889 Compare September 29, 2020 19:10
@willemarcel willemarcel merged commit 090ed19 into develop Sep 29, 2020
yunjuc pushed a commit to yunjuc/tasking-manager that referenced this pull request Oct 3, 2020
* add sentry integration

* add sentry integration to frontend + adjust backend sample_rate

* Add environment envvar for sentry

* Add sentry dsn envvars for deployment

Co-authored-by: Dakota Benjamin <[email protected]>
willemarcel added a commit that referenced this pull request Oct 22, 2020
* add sentry integration

* add sentry integration to frontend + adjust backend sample_rate

* Add environment envvar for sentry

* Add sentry dsn envvars for deployment

Co-authored-by: Dakota Benjamin <[email protected]>
@willemarcel willemarcel deleted the feature/sentry-backend-integration branch October 22, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants