Improve dockerfiles #3648
Merged
Improve dockerfiles #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frafra
force-pushed
the
improve-dockerfiles
branch
from
dfd9d07
to
8cb1273
Compare
willemarcel
approved these changes
Oct 12, 2020
willemarcel
pushed a commit
that referenced
this pull request
Oct 22, 2020
* Optimize and improve Dockerfile.backend * Optimize and improve Dockerfile.frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3638 and greatly improves existing Dockerfiles: images are way smaller, faster to recreate and some backend options (like workers/threads/timeout) can be also set by using environmental variables.
The newly added variables for the backend could be added to the compose file too (commented?), to make them more visible to the user.