Refactor name and URL CustomEditorForm inputs #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
force-pushed
the
refactor/custom-editor-inputs
branch
from
a4705ac
to
ff4d979
Compare
willemarcel
suggested changes
Nov 10, 2020
There was a problem hiding this comment.
@d-rita a small suggestion of change. Also make sure to have the git pre-commit hook setup, so the indentation of customEditor file will be fixed (it's the only file with 4 spaces indentation on the frontend)
- Create a CustomEditorTextInput component - Add conditional rendering of the input label - Refactor name and url inputs using new component
d-rita
force-pushed
the
refactor/custom-editor-inputs
branch
from
ff4d979
to
a4b3d96
Compare
willemarcel
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor text inputs in the CustomEditorForm
Steps Taken