Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style project edit section checkbox inputs #3866

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Nov 11, 2020

What does this PR do?

  • Styles the checkbox inputs in the Project Edit section to match the ones in the Notifications.

Issues:
Fixes #3799

Screenshot:

  • Settings Form: Editors for mapping and validation

checkboxes

  • Metadata Form: Mapping types

mapping_type

- use checkbox component for mapping and validation editors
- use checkbox component for mapping types in the metadata form
- define checkbox labels using aria tags
@d-rita d-rita force-pushed the refactor/project-edit-checkbox-inputs branch from 0c7da49 to 0593f74 Compare November 12, 2020 08:26
Copy link
Contributor

@willemarcel willemarcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! Fantastic change. I liked the arial-label usage!

@willemarcel willemarcel merged commit 73b88fc into develop Nov 12, 2020
@willemarcel willemarcel deleted the refactor/project-edit-checkbox-inputs branch November 12, 2020 13:50
@willemarcel willemarcel added this to the 4.2.1 milestone Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: frontend status: done type: enhancement Improving an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style checkbox inputs on project edit page
2 participants