Refactor Campaign Service and Campaign static methods #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
force-pushed
the
refactor/campaign-service-methods
branch
from
e17c2a7
to
c726e4c
Compare
|
I like the new structure. We are not supporting to assign organizations with campaigns on the frontend and we are not using that information of organizations related to a campaign. I think the best would be to remove that organization field from the campaign detail endpoint. When we have that need we can build a new endpoint: |
d-rita
force-pushed
the
refactor/campaign-service-methods
branch
from
0fe8259
to
7a2fdcb
Compare
- Add separate method to get campaign organisations - Move similar methods from Campaign model to Campaign service - Add new method to return CampaignListDTO - Remove organisation detail from returned campaign
d-rita
force-pushed
the
refactor/campaign-service-methods
branch
from
7a2fdcb
to
fbe6a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the Campaign and Campaign Service static methods.
Steps Taken:
Some of the URLs to test:
GET.http://127.0.0.1:5000/api/v2/campaigns/http://127.0.0.1:5000/api/v2/campaigns/<int:campaign_id>/http://127.0.0.1:5000/api/v2/organisations/<int:organisation_id>/campaigns/http://127.0.0.1:5000/api/v2/projects/<int:project_id>/campaigns/http://localhost:3000/manage/campaigns/http://localhost:3000/manage/campaigns/<int:campaign_id>