Search for projects by exact mapping type #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemarcel
suggested changes
Nov 20, 2020
d-rita
force-pushed
the
refactor/project-search-mapping-type
branch
from
fad3fff
to
5bdb9e6
Compare
d-rita
changed the title
d-rita
added
status: in progress
Status: On Discussion
type: enhancement
d-rita
changed the title
- Add mappingTypesExact search param - Add new query to return only projects matching the requested types if mappingTypesExact is true - Add query to return all projects with any of the mapping types for mappingTypesExact is false - Add mappingTypesExact param to docstrings
d-rita
force-pushed
the
refactor/project-search-mapping-type
branch
from
8a8b594
to
2141fae
Compare
willemarcel
approved these changes
Nov 26, 2020
|
@d-rita I added the field on the frontend. Could you test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Give the user the option of searching for projects matching the exact mapping type or get all projects that contain the mapping type.
Steps Taken:
Related issues:
#3852
Test:
GETmethod, test for projects of different mapping types using:http://127.0.0.1:5000/api/v2/projects/?mappingTypes=<string:mapping_type>&mappingTypesExact=truehttp://127.0.0.1:5000/api/v2/projects/?mappingTypes=ROADS&mappingTypesExact=true