Request users to view task history comments #3954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
changed the title
d-rita
force-pushed
the
feature/user-should-read-task-history-comments
branch
from
88f259a
to
0869db6
Compare
willemarcel
suggested changes
Dec 7, 2020
There was a problem hiding this comment.
Thanks, @d-rita!
We need some adjustments:
- Only show the message if:
- The task has been invalidated previously (check the history for a STATE_CHANGE to INVALIDATED
- There is at least one comment on the history (the history includes both comments and state changes)
- Let's try to use a tooltip instead of a banner? When I click on the history tab, it's flicking to the top. I think a tooltip will call more attention from the user too.
- add info svg icon - add banner request to view task history comments - conditional render of banner if task was invalidated and has comments
d-rita
force-pushed
the
feature/user-should-read-task-history-comments
branch
from
86e997f
to
3e9b02e
Compare
willemarcel
approved these changes
Dec 15, 2020
willemarcel
deleted the
feature/user-should-read-task-history-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #3507
Steps taken:
Screenshot:
