Allow users to filter task history comments and state changes #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-rita
added
status: in progress
type: enhancement
- Add checkboxes for comments and state changes - Adjust styling for action tabs - Automatic render of comments for beginner mappers
d-rita
force-pushed
the
feature/filter-task-history
branch
from
2b46967
to
80f9478
Compare
willemarcel
suggested changes
Dec 21, 2020
There was a problem hiding this comment.
@d-rita it's working pretty well, some suggestions on style:
On the task history modal, we need to align it better:
Probably setting it with the same alignment as the history items would be good
Another suggestion is to replace "Task changes" by "Actions" or "Activities".
| const token = useSelector((state) => state.auth.get('token')); | ||
| const [history, setHistory] = useState([]); | ||
| const [showTaskComments, setShowTaskComments] = useState(false); |
There was a problem hiding this comment.
It would be better to start both showTaskComments and showTaskChanges as true and make showTaskChanges as false if the user is begginer, so the user understands what is activated.
willemarcel
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #3977
Screenshots: