Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make organisation a required field for each project #4095

Merged
merged 6 commits into from
Jan 19, 2021

Conversation

d-rita
Copy link
Contributor

@d-rita d-rita commented Jan 13, 2021

What does this PR do?
Implement the frontend for #3623

Screenshots:

  1. Project Create

Screenshot 2021-01-18 at 16 50 05

  1. Project Edit
  • Error message

Screenshot 2021-01-13 at 05 58 07

Copy link
Contributor

@willemarcel willemarcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small improvement suggestion...

frontend/src/views/projectEdit.js Show resolved Hide resolved
@willemarcel willemarcel added this to the v4.2.5 milestone Jan 13, 2021
@willemarcel willemarcel added the type: enhancement Improving an existing functionality label Jan 13, 2021
@d-rita d-rita force-pushed the feature/required-organisation-field branch from f904086 to 038e358 Compare January 18, 2021 15:25
@willemarcel
Copy link
Contributor

@ramyaragupathy @d-rita I pushed some improvements (including on the backend) and I would like to have a review from you

Copy link
Contributor Author

@d-rita d-rita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willemarcel, this works well.

@willemarcel willemarcel force-pushed the feature/required-organisation-field branch from f38728e to 03bd86f Compare January 19, 2021 09:38
@willemarcel willemarcel merged commit 801c446 into develop Jan 19, 2021
@willemarcel willemarcel deleted the feature/required-organisation-field branch January 19, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants