Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status filters by making them independent on manage project page #4711

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Improve status filters by making them independent on manage project page #4711

merged 1 commit into from
Jun 3, 2021

Conversation

NatashaKSS
Copy link
Contributor

Description

This PR's main goal is to solve the linked issue by creating a new status filter called "Managed by Me", so that users can select projects managed by them that have been archived. Currently, there's no way to do so because "Archived" and "Created by Me" filters are mutually exclusive.

We also improve the status filter toggling behaviour by making "Active", "Draft" & "Archived" filters separate from "Created by Me" and "Managed by Me". These filters have also been tested on mobile-sized screens to make sure they aren't awkwardly aligned.

(Beware: Unfamiliar with business logic)
Feel free to comment if I might have misunderstood the requirements here. I think it's easier to implement what I think should be the logic in code, and then work on this from here as a baseline.

Fixes #3829

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Run yarn start in the ./frontend folder
  • Navigate to the page Manage > View all projects
  • Verify that filters can be toggled independently from each other
    • For projects "Created by Me", toggle each one of "Active", "Draft" & "Archived" filters
    • For projects "Managed by Me", toggle each one of "Active", "Draft" & "Archived" filters
  • Run yarn test in the ./frontend folder. There were no unit tests for this file, so I tested my implementation on the UI.

Here is a reference screenshot (larger screens):

image

(mobile screens)

image

Copy link
Contributor

@willemarcel willemarcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, @NatashaKSS!!! It's very easy to review your pull requests! Thanks a lot for your collaboration! ❤️

@willemarcel willemarcel merged commit d2f0d89 into hotosm:develop Jun 3, 2021
@willemarcel willemarcel added this to the v4.4.8 milestone Jun 3, 2021
@willemarcel willemarcel added status: done type: enhancement Improving an existing functionality UX labels Jun 3, 2021
@NatashaKSS NatashaKSS deleted the feature/3829-manage-projects-multi-filter branch July 1, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: frontend status: done type: enhancement Improving an existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Search Criteria on Manage Projects page
2 participants