Add second banner for summit #4919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
This looks great! Do you think an we get a button for the registration link directly? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Russ, I've created a banner for the HOT Summit to add to the tasking manager. I'm not sure if this should be merged upstream or if there is a separate deployment for the HOT-specific TM.
First time a user visits the site:
Hiding behind that first banner is information about the summit:
In the past, we've had issues with temporary banners not retaining user's close preference and getting annoying; based on brief testing, the browser seems to hold the preferences since I mimicked the tracking banner's browser storage.
I originally wanted to do a broader solution based on a database table for announcements, but wasn't able to get that finished up in time. That may come down the road.