Rapid Integration

[zlavergne]

This is the long awaited RapiD integration. This PR embeds RapiD the same way iD is currently embedded in the TM.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
1.0% Duplication

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
1.0% Duplication

[zlavergne]

This is now ready to go!

[HelNershingThapa]

Hi, @zlavergne I'm trying to test the integration locally and the icons don't seem to appear.

I did run the 'update-static' script. Did I miss something?

[Aadesh-Baral]

@HelNershingThapa This seems be an issue with the RapiD release build tag on ./frontend/package.json . Changing "RapiD": "facebookincubator/rapid#rapid-v1.1.8-TM" to "RapiD": "facebookincubator/rapid#rapid-v1.1.8_tm" loaded the icons. @zlavergne can you please verify it?

[zlavergne]

@Aadesh-Baral that's correct. We had an issue with the previous tag so we had to remove the old one and create a new reference. Simply changing the tag in the package.json will fix the issue.

[zlavergne]

@HelNershingThapa @Aadesh-Baral Let me know if you want me to update the PR to reflect this. I thought I had updated it after making the changes upstream but it seems I forgot.

[Aadesh-Baral]

@zlavergne We tried deploying a development instance of this integration but ran into some CORS issues on our server (but it was all good on 127.0.0.1). I think we need to verify if all of the tasking managers instances are added to allowed origins. Can you please verify that? Other than that I think we are good to go.

[zlavergne]

Yes, you need to change localhost to 127.0.0.1 for local dev. We added hotosm.org to our allowed domains a while ago for the Nesta experiment. You shouldn't have CORS issues when deploying to a hotosm.org domain

[zlavergne]

I will work to get all of the domains listed in instances section of the README added to our allowlist. I'll keep you updated @Aadesh-Baral

[Aadesh-Baral]

Ok thanks, @zlavergne. It would also be great if you could update PR with an updated released tag.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

No Coverage information
1.0% Duplication

[zlavergne]

@Aadesh-Baral The branch has been updated with the correct tag. I've also submitted an internal review to update the allowlist. I'll let you know when it's productionized.

[zlavergne]

@Aadesh-Baral My internal changes have landed. All of the domains listed in the Instances section of the README should be able to make requests without issue 🙂

[Aadesh-Baral]

Great work @zlavergne !! Planning to merge this today.