Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cfn init codedeploy #5046

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix/cfn init codedeploy #5046

merged 2 commits into from
Mar 21, 2022

Conversation

dakotabenjamin
Copy link
Member

Fixes an issue with server initialization. We move the codedeploy init to the end of the script (Based on these suggestions https://docs.aws.amazon.com/codedeploy/latest/userguide/integrations-aws-auto-scaling.html#integrations-aws-auto-scaling-behaviors) and add a 60 second wait, to allow server init apt package lock to release.

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@eternaltyro eternaltyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -340,6 +340,7 @@ const Resources = {
UserData: cf.userData([
'#!/bin/bash',
'set -x',
'sleep 60',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could optionally complicate things by writing a check to see if apt process is locked. Something like this: https://gist.github.com/tedivm/e11ebfdc25dc1d7935a3d5640a1f1c90

@dakotabenjamin dakotabenjamin merged commit 3e808a1 into develop Mar 21, 2022
@dakotabenjamin dakotabenjamin mentioned this pull request Apr 5, 2022
@eternaltyro eternaltyro deleted the fix/cfn-init-codedeploy branch February 10, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Deployed to production
Development

Successfully merging this pull request may close these issues.

2 participants