Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabs to preview markdown content for project detail comment section #5094

Merged

Conversation

HelNershingThapa
Copy link
Contributor

This PR adds tabs to write and preview markdown content in the comment section of the project detail page.

Screenshot:
Write
write-comment

Preview
preview-comment

Also, horizontal resizing of textarea has been disabled.

@HelNershingThapa HelNershingThapa marked this pull request as draft April 12, 2022 17:31
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

&:focus-within {
outline: -webkit-focus-ring-color auto 1px;
.textareaDetail {
border-bottom-color: transparent;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small spacing caused by the 'rta' class from react-textarea-autocomplete, which wouldn't allow the parent div contained to outline its child elements.

@HelNershingThapa HelNershingThapa marked this pull request as ready for review May 18, 2022 04:10
@HelNershingThapa HelNershingThapa merged commit 3de4f49 into hotosm:develop May 18, 2022
HelNershingThapa added a commit to HelNershingThapa/tasking-manager that referenced this pull request May 26, 2022
…on (hotosm#5094)

* Add tabs to preview markdown content for project detail comment section

* Added outline for textarea parent element
HelNershingThapa added a commit to HelNershingThapa/tasking-manager that referenced this pull request Jun 6, 2022
…on (hotosm#5094)

* Add tabs to preview markdown content for project detail comment section

* Added outline for textarea parent element
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to preview markdown content before sending comments and messages
1 participant