Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable support to select username already in members #5095

Conversation

HelNershingThapa
Copy link
Contributor

This PR adds error messages for corresponding error subcodes while updating team members. Selecting users from dropdown options who are already team members has been disabled. A helper text 'Already in team' is displayed in the option if the user is already a team member.

Screenshots:

already-a-member-error

disabled-option

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@HelNershingThapa HelNershingThapa marked this pull request as ready for review May 23, 2022 04:54
@HelNershingThapa HelNershingThapa merged commit b68eb13 into hotosm:develop May 23, 2022
HelNershingThapa added a commit to HelNershingThapa/tasking-manager that referenced this pull request May 26, 2022
* Disable support to select username already in members and add corresponding subcodeerror message

* Display error message while adding managers
HelNershingThapa added a commit to HelNershingThapa/tasking-manager that referenced this pull request Jun 6, 2022
* Disable support to select username already in members and add corresponding subcodeerror message

* Display error message while adding managers
@HelNershingThapa HelNershingThapa deleted the feature/5074-display-error-messages branch June 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show Operational Error Message to Users
1 participant