-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle switching editors with unsaved edits #5096
Handle switching editors with unsaved edits #5096
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I've added an error popup that shows up when trying to switch to JOSM. Other than that, I tested the switching process locally, looks good to me @Aadesh-Baral |
@@ -28,6 +28,7 @@ | |||
"@turf/transform-scale": "^6.4.0", | |||
"@turf/truncate": "^6.4.0", | |||
"@webscopeio/react-textarea-autocomplete": "^4.7.3", | |||
"RapiD": "facebookincubator/rapid#rapid-v1.1.8-tm.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will removing the previously installed RapiD dependency(rapid-v1.1.8_tm) be safe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be totally safe. Making the editors be different components instead of reloading the page required a few changes to RapiD as well. It will basically function as an update to the RapiD dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed on 27ab132
There was a problem reported with the RapiD integration when a user would attempt to switch editors from RapiD to iD when the user still had unsaved edits (#5025)
This PR does 3 main things to solve this issue:
UnsavedMapChangesModalContent
component to show an alert if a user still has unsaved edits and tries to switch editorsCloses #5025