-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ability for users to select tasks they mapped #5953
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Per chat w/ @HelNershingThapa and @Aadesh-Baral following are the next steps:
|
- Emend popup text to "This task was mapped by you" - Remove the not-allowed cursor implementation
- Enhances the `LockError` modal by introducing a "Deselect and Continue" button. The button is displayed when a `CannotValidateMappedTask` task lock error occurs. The "Close" button is shown with the primary variant when only a single task is selected. - Conditionally displayed the buttons based on the user's selected tasks and mapping status. - Separated the action buttons into a new component named `LockErrorButtons`. - Moved the logic for handling task deselection and validation into the `LockErrorButtons` component. - Updated the existing test cases to reflect the new changes made in the `LockErrorButtons` component.
9d42fc7
to
f1f1acd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
For now, we are not including task numbers in the pop-up and keep the message minimal. This can be later added if the users find it beneficial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this feature and reviewed the code, all good!
Resolves #5435
Changes Made
LockErrorButtons
component, which also handles task deselection and validation logic.