Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requires-python version to ">=3.10,<=3.11" #6013

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

Aadesh-Baral
Copy link
Contributor

@Aadesh-Baral Aadesh-Baral commented Aug 3, 2023

This PR modifies the requires-python constraint in the pyproject.toml file to ensure that the Python version used for this project remains between 3.10 and 3.11. By locking the Python version in this range, we guarantee that the generated lock file will be based on Python 3.10, which aligns with the production setup requirements.

With this change PyYAML is also updated to 6.0.1 which fixes partly #5997.

This commit modifies the requires-python constraint in the pyproject.toml file to ensure that the Python version used for this project remains between 3.10 and 3.11. By locking the Python version in this range, we guarantee that the generated lock file will be based on Python 3.10, which aligns with the production setup requirements. This change helps maintain consistency and stability across environments and ensures compatibility with the selected Python version.
@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Aadesh-Baral Aadesh-Baral marked this pull request as ready for review August 3, 2023 07:39
@Aadesh-Baral Aadesh-Baral merged commit 3d62eac into develop Aug 4, 2023
3 checks passed
@Aadesh-Baral Aadesh-Baral deleted the fix/pyyaml-build-fail branch August 4, 2023 04:55
@dakotabenjamin
Copy link
Member

Staging server has been unable to instantiate since this PR. Error log from cloud-init-output below:

+ pdm install
STATUS: Resolving packages from lockfile...
python.use_venv is on, creating a virtualenv for this project...
See /tmp/pdm-install-resolve-v922ywfl.log for detailed debug log.
[VirtualenvCreateError]: Can't resolve python interpreter
++ pdm venv activate
The project doesn't have a saved python.path. Run pdm use to pick one.
+ eval ''
.
.
.
newrelic-admin run-program gunicorn -b 0.0.0.0:8000 --worker-class gevent --workers 5 --timeout 179 --access-logfile /var/log/tasking-manager-logs/gunicorn-access.log --access-logformat '%(h)s %(l)s %(u)s %(t)s "%(r)s" %(s)s %(b)s %(T)s "%(f)s" "%(a)s"' manage:application
/var/lib/cloud/instance/scripts/part-001: line 65: newrelic-admin: command not found

We probably need to update the UserData on Cloudformation to account for these changes.

@Aadesh-Baral
Copy link
Contributor Author

Aadesh-Baral added a commit that referenced this pull request Aug 15, 2023
Staging server was disrupted after merging #6013 due to python 3.10 not being present in server. So revering the changes made in PR #6013 to fix the issue for now
dakotabenjamin pushed a commit that referenced this pull request Aug 15, 2023
Staging server was disrupted after merging #6013 due to python 3.10 not being present in server. So revering the changes made in PR #6013 to fix the issue for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants