Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock tasks after validation using in parallel using python threads #6256

Merged

Conversation

kaditya97
Copy link
Member

@kaditya97 kaditya97 commented Feb 25, 2024

Copy link

sentry-io bot commented Feb 25, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: backend/services/validator_service.py

Function Unhandled Issue
unlock_tasks_after_validation AttributeError: 'NoneType' object has no attribute 'last_validation_date' tasksa...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@kaditya97 kaditya97 changed the title Fix/unlock after validation api threading for tasks Unlock tasks after validation using in parallel using python threads Feb 26, 2024
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@robsavoye
Copy link
Collaborator

Using SQLAlchemy sessions should fix the problem with thread contention when accessing the database. I can't run the backend yet, do the tests now pass ?

@kaditya97
Copy link
Member Author

Using SQLAlchemy sessions should fix the problem with thread contention when accessing the database. I can't run the backend yet, do the tests now pass ?

I used new SQLAlchemy session in each thread and passed the session as local session and it worked. Also all test are passing now.

@robsavoye robsavoye merged commit 10eb67c into develop Mar 6, 2024
8 checks passed
@ramyaragupathy ramyaragupathy added this to the v4.7.1 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks validation using python threads [BUG] Unable to submit tasks after validation
3 participants