-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partner Leaderboard #2 #6449
Partner Leaderboard #2 #6449
Conversation
@dgquail, the test cases are failing. Are you planning to solve them ? |
Hi @royallsilwallz, |
@emi420 |
Ok @lotjulieta ! but the migration works right? |
works right! |
@CristianAmici @emi420 there's an error when I try to add a new partner - |
Yes @royallsilwallz I see the same thing, let's wait for @CristianAmici to review the messages issues because this looks related. |
@CristianAmici , I can go to the "Create new partner" page now, but there's no "Save" button and I can't create one for testing: CC @dgquail |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're ready to go and merge this PR to develop 👍
CC @royallsilwallz @prabinoid @kaditya97 @ramyaragupathy @dgquail @CristianAmici @lotjulieta
Things that will be on our side before going to production:
- Improve CSS styling for some things
- Fix frontend code styling like spaces, imports order, etc
- Make
/partners/<permalink>
redirect to/partners/<permalink>/stats
- Fix failing tests for migrations
- Add partner's logo to the stats leaderboard
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
The Tasking Manager needs to have a partner information page within the product, together
with a management section for admins to create, list, edit and delete partners. Also, a list of
partners will be available
What type of PR is this? (check all applicable)
Related Issue
#6346
#6366
#6367
#6368
#6369
#6349
#6370
#6412
#6427
#6432
#6437
Describe this PR
This PR contains the development of the Partner administration section for TM. Backend and Fronted code
Screenshots
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?