Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Leaderboard #2 #6449

Merged
merged 45 commits into from
Jun 13, 2024
Merged

Partner Leaderboard #2 #6449

merged 45 commits into from
Jun 13, 2024

Conversation

dgquail
Copy link
Collaborator

@dgquail dgquail commented May 30, 2024

The Tasking Manager needs to have a partner information page within the product, together
with a management section for admins to create, list, edit and delete partners. Also, a list of
partners will be available

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

#6346
#6366
#6367
#6368
#6369
#6349
#6370
#6412
#6427
#6432
#6437

Describe this PR

This PR contains the development of the Partner administration section for TM. Backend and Fronted code

Screenshots

image
image
image

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@dgquail dgquail marked this pull request as ready for review May 30, 2024 21:07
@royallsilwallz royallsilwallz mentioned this pull request May 31, 2024
7 tasks
@royallsilwallz
Copy link
Contributor

@dgquail, the test cases are failing. Are you planning to solve them ?
cc - @emi420 @ramyaragupathy @manjitapandey

@dgquail
Copy link
Collaborator Author

dgquail commented May 31, 2024

@dgquail, the test cases are failing. Are you planning to solve them ? cc - @emi420 @ramyaragupathy @manjitapandey

Hi @royallsilwallz,
we will see them and let them know

docs/developers/development-setup.md Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
frontend/src/assets/img/learn-MapNow.svg Show resolved Hide resolved
frontend/src/components/teamsAndOrgs/currentProjects.js Outdated Show resolved Hide resolved
frontend/src/components/teamsAndOrgs/currentProjects.js Outdated Show resolved Hide resolved
frontend/src/components/teamsAndOrgs/partnersActivity.js Outdated Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
frontend/src/assets/img/learn-MapNow.svg Show resolved Hide resolved
frontend/src/views/partnersStats.js Outdated Show resolved Hide resolved
frontend/src/components/teamsAndOrgs/partners.js Outdated Show resolved Hide resolved
@lotjulieta
Copy link
Collaborator

lotjulieta commented Jun 6, 2024

test1
test2
test3

@emi420
The automatic tests are throwing errors related to a migration file that is automatically generated by Alembic. Please note that this file is not manually created by me, but by Alembic during the migration process.

@emi420
Copy link
Collaborator

emi420 commented Jun 6, 2024

Ok @lotjulieta ! but the migration works right?

@lotjulieta
Copy link
Collaborator

Ok @lotjulieta ! but the migration works right?

works right!

frontend/src/components/teamsAndOrgs/messages.js Outdated Show resolved Hide resolved
frontend/src/components/partners/partnersResourses.js Outdated Show resolved Hide resolved
frontend/package.json Show resolved Hide resolved
@royallsilwallz
Copy link
Contributor

@CristianAmici @emi420 there's an error when I try to add a new partner -

image

@emi420
Copy link
Collaborator

emi420 commented Jun 12, 2024

Yes @royallsilwallz I see the same thing, let's wait for @CristianAmici to review the messages issues because this looks related.

@emi420
Copy link
Collaborator

emi420 commented Jun 12, 2024

@CristianAmici , I can go to the "Create new partner" page now, but there's no "Save" button and I can't create one for testing:

Screenshot 2024-06-12 at 13 12 34

CC @dgquail

frontend/src/components/partners/messages.js Outdated Show resolved Hide resolved
frontend/src/components/partners/messages.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
45 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@emi420 emi420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're ready to go and merge this PR to develop 👍

CC @royallsilwallz @prabinoid @kaditya97 @ramyaragupathy @dgquail @CristianAmici @lotjulieta

Things that will be on our side before going to production:

  1. Improve CSS styling for some things
  2. Fix frontend code styling like spaces, imports order, etc
  3. Make /partners/<permalink> redirect to /partners/<permalink>/stats
  4. Fix failing tests for migrations
  5. Add partner's logo to the stats leaderboard

@emi420 emi420 merged commit d95bf65 into hotosm:develop Jun 13, 2024
4 of 7 checks passed
Copy link

sentry-io bot commented Jun 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrityError: (psycopg2.errors.NotNullViolation) null value in column "name" of relation "partners" violates no... partnersallrestapi View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants