Depend on nuget packages instead of submodule #64
Conversation
|
I'm not sure why the sln diff doesn't see any common parts. Maybe line endings? Do you have any specific preference for line endings in the sln file? |
Hotsapi.Uploader.Common/Analyzer.cs
Outdated
| @@ -22,7 +22,10 @@ public class Analyzer : IAnalyzer | |||
| public Replay Analyze(ReplayFile file) | |||
| { | |||
| try { | |||
| var result = DataParser.ParseReplay(file.Filename, false, false, false, true); | |||
| var parseOptions = new ParseOptions() { | |||
| AllowPTR = true | |||
There was a problem hiding this comment.
So I switched up the parse options from feedback provided by barrret before he merged your changes. So just wanted to make sure you saw those changes. Also, why allowPTR? The uploader doesn’t upload PTR games as far as I am aware
There was a problem hiding this comment.
The again, you have to parse PTR to know it’s PTR. So probably why.
There was a problem hiding this comment.
Indeed, that doesn't look right. The old method signature was ParseReplay(string fileName, bool ignoreErrors, bool deleteFile, bool allowPTRRegion = false, bool skipEventParsing = false, bool skipUnitParsing = false, bool skipMouseMoveEvents = false, bool detailedBattleLobbyParsing = false) so that's ignoreErrors = false, deleteFile = false, allowPTR = false, skipEventParseing = true, skipUnitParsing=false, skipMouseMoveEvents = false and detailedBattleLobbyParsing = false. But that's odd: why not skip mouse events. Closing this to look again.
There was a problem hiding this comment.
Could you maybe help me out with the versioning? I'm completely lost on where to find which commit is published in which version of the package.
There was a problem hiding this comment.
The owner of the repo requested the defaulted state be the same as the previous default state for consistently and reduce confusion. Which makes sense to me
There was a problem hiding this comment.
I opened barrett777/Heroes.ReplayParser#97
There was a problem hiding this comment.
I have the impression that the build error is related to GitVersion. I asked around at https://gitter.im/GitTools/GitVersion?at=5e29c4d2f85dba0aab003034
There was a problem hiding this comment.
@martijnhoekstra GitVersion is a development-only dependency. It shouldn't be included in or affect the NuGet package: https://github.com/barrett777/Heroes.ReplayParser/blob/master/Heroes.ReplayParser/Heroes.ReplayParser.csproj#L15-L16
There was a problem hiding this comment.
I did have issues in development with replays all returning Exception, and I think the issue was different versions of 'sharpcompress'. Do any other projects in this solution use it? I think you need to make sure they are all 0.24.0 or later
There was a problem hiding this comment.
A version mismatch of sharpcompress was indeed the issue. It's troublesome that exceptions are swallowed like this to debug this.
|
The |
No description provided.