Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for number values with underscores #693

Merged

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Jun 20, 2023

@lb- lb- force-pushed the feature/646-add-support-for-numeric-separators-numbers branch 2 times, most recently from 1643cea to a3ad946 Compare June 21, 2023 07:54
@lb- lb- force-pushed the feature/646-add-support-for-numeric-separators-numbers branch from a3ad946 to b23474f Compare June 21, 2023 08:00
@dhh dhh merged commit 4ef73b0 into hotwired:main Jun 24, 2023
@lb- lb- deleted the feature/646-add-support-for-numeric-separators-numbers branch June 24, 2023 12:30
@lb-
Copy link
Contributor Author

lb- commented Jun 24, 2023

Thanks for merging dhh

@@ -131,7 +131,7 @@ The list of supported modifier keys is shown below.

Sometimes a controller needs to listen for events dispatched on the global `window` or `document` objects.

You can append `@window` or `@document` to the event name (along with any filter modifier) in an action descriptor to install the event listener on `window` or `document`, respectively, as in the following example:
You can append `@window` or `@document` to the event name (along with any filter modifer) in an action descriptor to install the event listener on `window` or `document`, respectively, as in the following example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It was fixed though - see #704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Feature request - support numeric separators in number value attributes
3 participants