Set window.Turbo on import #280
Conversation
This makes sure Turbo is available for Request.js and Turbo Native out of the box.
|
Added a test to make sure the ESM module also sets This one should be ready to go @dhh @marcelolx |
|
are you sure that this a good idea @excid3 ? |
@michelson Have you a scenario where it would be a bad idea Turbo exposing itself to the window? I'm asking because I really don't know if there would be a problem or not |
|
I think this is indeed the better default, but I'd also like to see an option where someone could import Turbo without triggering window + autostart. That would be a separate build target, though. That's more of a nice-to-have. Having window.Turbo set is needed for all the native integrations anyway. And it makes it easier to drop Turbo into a site and start using it right away. |
the only scenario I can imagine right now is for example some sort of widget app that could be imported on sites (like chat widgets like intercom) I would expect that app will self contained and not mess with the rest of the app. |
…e-7)
This PR was squashed before being merged into the 2.x branch.
Discussion
----------
[Turbo] Fix TypeScript compilation issue... again
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| License | MIT
_webpack.config.js_:
```js
Encore
...
.enableTypeScriptLoader()
.enableForkedTypeScriptTypesChecking()
```
Error message on `yarn encore production`:
```
Failed to compile with 1 errors
error in vendor/symfony/ux-turbo/Resources/assets/src/turbo_controller.ts:14:8 11:22:22
TS2339: Property 'Turbo' does not exist on type 'Window & typeof globalThis'.
12 |
13 | // Expose Turbo to the rest of the app to allow for dynamic Turbo calls
> 14 | window.Turbo = Turbo;
| ^^^^^
15 |
16 | /**
17 | * Empty Stimulus controller only used for Symfony Flex wiring.
```
Previously, #331 proposed a different solution, but it was rejected due to the changes already being prepared in hotwired/turbo#280. At the moment, the changes in the second package have been made, as a result of which it is possible to change lines that cause a compilation error.
Commits
-------
25482a7 [Turbo] Fix TypeScript compilation issue... again
…e-7)
This PR was squashed before being merged into the 2.x branch.
Discussion
----------
[Turbo] Fix TypeScript compilation issue... again
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| License | MIT
_webpack.config.js_:
```js
Encore
...
.enableTypeScriptLoader()
.enableForkedTypeScriptTypesChecking()
```
Error message on `yarn encore production`:
```
Failed to compile with 1 errors
error in vendor/symfony/ux-turbo/Resources/assets/src/turbo_controller.ts:14:8 11:22:22
TS2339: Property 'Turbo' does not exist on type 'Window & typeof globalThis'.
12 |
13 | // Expose Turbo to the rest of the app to allow for dynamic Turbo calls
> 14 | window.Turbo = Turbo;
| ^^^^^
15 |
16 | /**
17 | * Empty Stimulus controller only used for Symfony Flex wiring.
```
Previously, #331 proposed a different solution, but it was rejected due to the changes already being prepared in hotwired/turbo#280. At the moment, the changes in the second package have been made, as a result of which it is possible to change lines that cause a compilation error.
Commits
-------
25482a7 [Turbo] Fix TypeScript compilation issue... again
This makes sure Turbo is available for Request.js and Turbo Native out
of the box.
Related to rails/request.js#6