Fixes #1834 Allow startConversationWithUser to work with Bot Framewor…

…k Emulator

changelog.md

@@ -13,7 +13,8 @@ This allows developers to use payload values inside quick replies, button clicks
 * NEW: Values in `channelData` will now be processed as Mustache templates inside BotkitConversations. [Thanks @me-cedric](https://github.com/me-cedric) for [pr #1925](https://github.com/howdyai/botkit/pull/1925)
 
 * FIX: Facebook Adapter will not attempt to set up web routes if webserver is not configured. [#1916](https://github.com/howdyai/botkit/issues/1916)
-
+* FIX: Exclude `activity.conversation.properties` field when generating state storage key. [#1849](https://github.com/howdyai/botkit/issues/1849)
+* FIX: Allow startConversationWithUser to work with Bot Framework Emulator. [#1834](https://github.com/howdyai/botkit/issues/1834)
 
 # 4.6.1
 

packages/botkit/src/botworker.ts

@@ -271,7 +271,9 @@ export class BotWorker {
         );
 
         const conversation: ConversationAccount = {
-            id: response.id,
+            // fallback to existing conversation id because Emulator will respond without a response.id AND needs to stay in same channel.
+            // This should be fixed by Emulator. https://github.com/microsoft/BotFramework-Emulator/issues/2097
+            id: response.id || reference.conversation.id,
             isGroup: false,
             conversationType: null,
             tenantId: null,

packages/testbot/features/botframework_features.js

@@ -8,7 +8,7 @@ module.exports = function(controller) {
             // this does not work with Bot Framework Emulator.
             // to achieve the same thing, use bot.changeContext(message.reference);
             await bot.startConversationWithUser(message.reference);
-            await bot.say('Hello! (in private');
+            await bot.say('Hello! (in private)');
         });
 
         controller.hears('update me', 'message', async(bot, message) => {