Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

use hmac compare instead of direct compare #1539

Merged
merged 2 commits into from
Dec 14, 2018
Merged

use hmac compare instead of direct compare #1539

merged 2 commits into from
Dec 14, 2018

Commits on Dec 11, 2018

  1. use hmac compare instead of direct compare 

    As per https://api.slack.com/docs/verifying-requests-from-slack - "Compare the resulting signature to the header on the request. Note: for best practice, use an hmac compare function instead of directly comparing the signatures for equality."
    @danhofer
    danhofer authored Dec 11, 2018
    Configuration menu
    Copy the full SHA
    56fecd0 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from danhofer/hmac-compare 

    use hmac compare instead of direct compare
    @danhofer
    danhofer authored Dec 11, 2018
    Configuration menu
    Copy the full SHA
    ee7b1b0 View commit details
    Browse the repository at this point in the history