This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Don't add activity and reference fields to outgoing message #1707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that Botkit adds some garbage fields to outgoing fields, e.g.
{"type":"message","text":"Hi...","channelId":"websocket","conversation":{"id":"98f515de-b10a-4b4c-51b9-d6fa3f0e1688"},"from":{"id":"bot"},"recipient":{"id":"98f515de-b10a-4b4c-51b9-d6fa3f0e1688"}}
So I decided to remove them.
Previous activity check was incorrect and allowed falsy values to be added to channelData.
Reference fields weren't checked at all so they were sent to client.