Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Remove implicit request dependency #2185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

draaglom
Copy link

@draaglom draaglom commented Jan 8, 2022

Motivation: request is implicitly depended on by
botbuilder-adapter-slack but it's not in package.json.

This means we want to either:

  • Add it as an explicit dependency
  • Remove it entirely

Given request is long since deprecated and usage in
botbuilder-adapter-slack is minimal (just this one request), the
latter seems most sensible.

Of candidate HTTP clients to swap out, node-fetch seems the obvious choice:

  • It's very small
  • It's popular
  • some of the botbuilder/botkit packages depend on it already

Where I'd like your advice with this PR:

  • This is technically a breaking change for anyone who is depending on getting errors specifically from Request
  • I've bumped to a v2 package-lock in the process, hope you don't mind
  • I've bumped down the dependency from botbuilder-adapter-slack to botkit to version 4.10 since npm couldn't find a 4.15, but this could just be my unfamiliarity with how lerna works (?)

Since there's no 4.15 published, an `npm install` fails in the
botbuilder-adapter-slack subpackage.
Motivation: `request` is implicitly depended on by
botbuilder-adapter-slack but it's not in package.json.

This means we need to either:
* Add it as a dependency
* Remove it entirely

Given `request` is long since deprecated and usage in
`botbuilder-adapter-slack` is minimal (just this one request), the
latter seems most sensible.

Of candidate HTTP clients to swap out, node-fetch seems the obvious choice:

* It's very small
* It's popular
* some of the botbuilder/botkit packages depend on it already
@ghost
Copy link

ghost commented Jan 8, 2022

CLA assistant check
All CLA requirements met.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@benbrown benbrown removed the stale label Apr 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants