This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
slackbutton_bot.js redirectUri Bug Fix #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchurch
changed the title
This was referenced Sep 4, 2020
This was referenced Apr 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #510
I introduced a bug in #465 by adding
process.env.redirectUrias a required variable to run slackbutton_bot.js example.redirectUriis an optional parameter that is part of the slackbutton oauth flow, and as such should not be required to run the file.This removes that requirement, and comments out redirectUri in the bot's config while pointing it out as an optional parameter.