Fix: Wrong detection of HM-300 inverters

Was introduced in v23.8.1; Fixes #1198
hoylabs · Aug 2, 2023 · 686112e · 686112e
1 parent 77528f6
commit 686112e
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/lib/Hoymiles/src/parser/DevInfoParser.cpp b/lib/Hoymiles/src/parser/DevInfoParser.cpp
@@ -210,15 +210,19 @@ uint8_t DevInfoParser::getDevIdx()
             && devInfo[pos].hwPart[2] == _payloadDevInfoSimple[4]
             && devInfo[pos].hwPart[3] == _payloadDevInfoSimple[5]) {
             ret = pos;
+            break;
         }
     }
 
-    // Then only for 3 bytes
-    for (pos = 0; pos < sizeof(devInfo) / sizeof(devInfo_t); pos++) {
-        if (devInfo[pos].hwPart[0] == _payloadDevInfoSimple[2]
-            && devInfo[pos].hwPart[1] == _payloadDevInfoSimple[3]
-            && devInfo[pos].hwPart[2] == _payloadDevInfoSimple[4]) {
-            ret = pos;
+    // Then only for 3 bytes but only if not already found
+    if (ret == 0xff) {
+        for (pos = 0; pos < sizeof(devInfo) / sizeof(devInfo_t); pos++) {
+            if (devInfo[pos].hwPart[0] == _payloadDevInfoSimple[2]
+                && devInfo[pos].hwPart[1] == _payloadDevInfoSimple[3]
+                && devInfo[pos].hwPart[2] == _payloadDevInfoSimple[4]) {
+                ret = pos;
+                break;
+            }
         }
     }