Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webapp autocompile #1193

Merged
merged 16 commits into from
Sep 5, 2024
Merged

Add webapp autocompile #1193

merged 16 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. add pre script to check if webapp changed and auto compile

    @spcqike @schlimmchen
    spcqike authored and schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ba78923 View commit details
    Browse the repository at this point in the history

  2. remove trailing whitespace

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3fad320 View commit details
    Browse the repository at this point in the history

  3. avoid running code if loaded as module

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    585982d View commit details
    Browse the repository at this point in the history

  4. do not execute if run by github action 

    the github action workflow is designed such that it builds the webapp in
a seprate step. we will keep that workflow the way it is because it
should be a seperate step, which the workflow makes clear.
    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    548398c View commit details
    Browse the repository at this point in the history

  5. remove comments (wrong language, not very helpful)

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a80ee3f View commit details
    Browse the repository at this point in the history

  6. move function up 

    declare functions earlier than they are called, which aids reading the
code.
    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    cfeae3a View commit details
    Browse the repository at this point in the history

  7. __name__ is not __main__ 

    but "SCons.Script"... let's copy from other pio scripts, which just call
main().
    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b27a2ee View commit details
    Browse the repository at this point in the history

  8. fix test for github actions 

    am I too tired or what ;)
    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    962f672 View commit details
    Browse the repository at this point in the history

  9. move hash file to webapp_dist

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    035fc84 View commit details
    Browse the repository at this point in the history

  10. refactor: inline do_compile()

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b8cf468 View commit details
    Browse the repository at this point in the history

  11. only look at webapp/src

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a49e024 View commit details
    Browse the repository at this point in the history

  12. clean out webapp_dist folder and ignore it

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b61f156 View commit details
    Browse the repository at this point in the history

  13. also inspect webapp/public and selected single files

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5382a15 View commit details
    Browse the repository at this point in the history

  14. show user-friendly message if yarn seems not to be available

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a9e2c16 View commit details
    Browse the repository at this point in the history

  15. inline calculate_hash function

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f71b9a4 View commit details
    Browse the repository at this point in the history

  16. unindent code that does compile the web app

    @schlimmchen
    schlimmchen committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    af1084c View commit details
    Browse the repository at this point in the history