Allow higher-resolution SoC in live view header

[ranma]

Commit accc70d added the battery SoC to the live view header. But due to getSoC returning an int the precision is currently limited.

This changes getSoC to return float so when a source with higher precision is available the full precision is shown.

[AndreasBoehm]

Good catch!
@schlimmchen do you know anyone with a Victron SmartShunt, which is the only source which provides decimals for SoC, that could test this?

[schlimmchen]

I guess @ranma can show us a respective screenshot and then we'll believe that it works. However, I think we need to use %.1f as the format specifier when printing the SoC, afaik otherwise the float will print with way too many decimals?

[ranma]

I guess @ranma can show us a respective screenshot and then we'll believe that it works.

Not until I've set up an emulation test rig. I had to switch the battery back to victron protocol for the time being and I don't have remote access to the console.

However, I think we need to use %.1f as the format specifier when printing the SoC, afaik otherwise the float will print with way too many decimals?

Yeah, that's probably not a bad idea. For some files like PylontechCanReceiver.cpp it may even make more sense to store the integer temporary and keep the format as %d :)

[ranma]

Screenshot from replaying Victron BMV702 logs I found on https://github.com/karioja/vedirect/blob/master/test/bvm702.dump:

$ stty raw 19200 < /dev/ttyUSB0 
$ cat /tmp/bvm702.dump  > /dev/ttyUSB0

[ranma]

However, I think we need to use %.1f as the format specifier when printing the SoC, afaik otherwise the float will print with way too many decimals?

Well, looking again the existing log printfs for voltage (which is already float with 2 decimals after the point) also uses just %f, so it should be fine as-is.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.